Machine ID: More rules to gitlab joining and add globby matching to some fields#34290
Merged
strideynet merged 13 commits intomasterfrom Nov 9, 2023
Merged
Machine ID: More rules to gitlab joining and add globby matching to some fields#34290strideynet merged 13 commits intomasterfrom
gitlab joining and add globby matching to some fields#34290strideynet merged 13 commits intomasterfrom
Conversation
Contributor
|
🤖 Vercel preview here: https://docs-duygl3bl0-goteleport.vercel.app/docs/ver/preview |
Contributor
Author
|
Manually requesting the people the bot attempted to assign - but failed due to the GitHub perms issue. |
hugoShaka
approved these changes
Nov 7, 2023
marcoandredinis
approved these changes
Nov 7, 2023
Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
Contributor
|
🤖 Vercel preview here: https://docs-b7gci0nlg-goteleport.vercel.app/docs/ver/preview |
ptgott
approved these changes
Nov 7, 2023
Contributor
ptgott
left a comment
ptgott
left a comment
There was a problem hiding this comment.
Approved with minor comments
public-teleport-github-review-bot
Bot
removed the request for review
from zmb3
Contributor
|
🤖 Vercel preview here: https://docs-ihejyudi7-goteleport.vercel.app/docs/ver/preview |
Contributor
|
🤖 Vercel preview here: https://docs-mj4v4q4mw-goteleport.vercel.app/docs/ver/preview |
Contributor
|
🤖 Vercel preview here: https://docs-6d7vfnuan-goteleport.vercel.app/docs/ver/preview |
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Nov 10, 2023
… some fields (#34290) * Add fields for to-be-supported token claims * Modify validation to include new field * Add comparisons for new fields to joining logic * Add support for globby matching for sub, ref, namespace_path and project_path * Document which fields support globby matching * Add tests for join rule engine changes * Regenerate operator CRDs * Add docs for new fields * Correct punctuation in error message Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> * Correctly use GoDoc-esque comments * Address docs comments * Reuse glob matching code * Correct type of RunnerID field --------- Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
strideynet
added a commit
that referenced
this pull request
Nov 10, 2023
… some fields (#34290) * Add fields for to-be-supported token claims * Modify validation to include new field * Add comparisons for new fields to joining logic * Add support for globby matching for sub, ref, namespace_path and project_path * Document which fields support globby matching * Add tests for join rule engine changes * Regenerate operator CRDs * Add docs for new fields * Correct punctuation in error message Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com> * Correctly use GoDoc-esque comments * Address docs comments * Reuse glob matching code * Correct type of RunnerID field --------- Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
… some fields (#34290) (#34465) * Add fields for to-be-supported token claims * Modify validation to include new field * Add comparisons for new fields to joining logic * Add support for globby matching for sub, ref, namespace_path and project_path * Document which fields support globby matching * Add tests for join rule engine changes * Regenerate operator CRDs * Add docs for new fields * Correct punctuation in error message * Correctly use GoDoc-esque comments * Address docs comments * Reuse glob matching code * Correct type of RunnerID field --------- Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
… some fields (#34290) (#34464) * Add fields for to-be-supported token claims * Modify validation to include new field * Add comparisons for new fields to joining logic * Add support for globby matching for sub, ref, namespace_path and project_path * Document which fields support globby matching * Add tests for join rule engine changes * Regenerate operator CRDs * Add docs for new fields * Correct punctuation in error message * Correctly use GoDoc-esque comments * Address docs comments * Reuse glob matching code * Correct type of RunnerID field --------- Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitLab have paid their OIDC impl some attention and there's a bunch of additional fields we can integrate with now.
Closes #34199
I've also added rudimentary globby matching support to
sub,ref,namespace_pathandproject_path- this allows for more flexibility in organisations that have a large number of repositories and use GitLab's subgrouping mechanism.changelog: New rule fields supported for
gitlabjoining and globby matching support forsub,ref,namespace_pathandproject_path. See https://goteleport.com/docs/machine-id/reference/gitlab/ for details.