[v14] Remove version warnings in Details boxes#34429
Merged
zmb3 merged 1 commit intobranch/v14from Nov 15, 2023
Merged
Conversation
github-actions
Bot
requested review from
r0mant,
stevenGravy,
xinding33 and
zmb3
ptgott
force-pushed
the
paul.gottschling/34413-bp-v14
branch
from
bb6c306 to
2c30609
Compare
zmb3
approved these changes
Nov 10, 2023
Backports #34413 Fixes #29913 The `Details` box is the wrong component for a version warning, since this box is meant for users to expand and collapse, and there is no benefit of expanding and collapsing a version warning. Depending on the guide, this change either: - Integrates the version warning into the Prerequisites section of a how-to guide - Makes the version warning regular text within the introductory section
ptgott
force-pushed
the
paul.gottschling/34413-bp-v14
branch
from
2c30609 to
0f83a99
Compare
zmb3
approved these changes
Nov 14, 2023
stevenGravy
approved these changes
Nov 14, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #34413
Fixes #29913
The
Detailsbox is the wrong component for a version warning, since this box is meant for users to expand and collapse, and there is no benefit of expanding and collapsing a version warning. Depending on the guide, this change either: