Remove version warnings in Details boxes#34413
Merged
Conversation
Fixes #29913 The `Details` box is the wrong component for a version warning, since this box is meant for users to expand and collapse, and there is no benefit of expanding and collapsing a version warning. Depending on the guide, this change either: - Integrates the version warning into the Prerequisites section of a how-to guide - Makes the version warning regular text within the introductory section
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
1 similar comment
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Contributor
|
🤖 Vercel preview here: https://docs-2flabo2xn-goteleport.vercel.app/docs/ver/preview |
zmb3
approved these changes
Nov 9, 2023
ptgott
added
the
no-changelog
stevenGravy
approved these changes
Nov 9, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
ptgott
added a commit
that referenced
this pull request
Nov 9, 2023
Backports #34413 Fixes #29913 The `Details` box is the wrong component for a version warning, since this box is meant for users to expand and collapse, and there is no benefit of expanding and collapsing a version warning. Depending on the guide, this change either: - Integrates the version warning into the Prerequisites section of a how-to guide - Makes the version warning regular text within the introductory section
ptgott
added a commit
that referenced
this pull request
Nov 13, 2023
Backports #34413 Fixes #29913 The `Details` box is the wrong component for a version warning, since this box is meant for users to expand and collapse, and there is no benefit of expanding and collapsing a version warning. Depending on the guide, this change either: - Integrates the version warning into the Prerequisites section of a how-to guide - Makes the version warning regular text within the introductory section
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
Backports #34413 Fixes #29913 The `Details` box is the wrong component for a version warning, since this box is meant for users to expand and collapse, and there is no benefit of expanding and collapsing a version warning. Depending on the guide, this change either: - Integrates the version warning into the Prerequisites section of a how-to guide - Makes the version warning regular text within the introductory section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29913
The
Detailsbox is the wrong component for a version warning, since this box is meant for users to expand and collapse, and there is no benefit of expanding and collapsing a version warning. Depending on the guide, this change either: