Skip to content

Unified resources view improvements #34384

Merged
gzdunek merged 7 commits intomasterfrom
gzdunek/unified-resources-improvements
Nov 10, 2023
Merged

Unified resources view improvements #34384
gzdunek merged 7 commits intomasterfrom
gzdunek/unified-resources-improvements

Conversation

@gzdunek
Copy link
Copy Markdown
Contributor

@gzdunek gzdunek commented Nov 9, 2023

This PR addresses some minor issues in the UnifiedResources that were found during the work on integrated search bar in Connect.
I also changed the loading cards styling a bit (this was feedback from Kenny)
Before:
image

After:
image

While I was on it, I refactored it slightly. There is no need in setting up setTimeout 24 times if we can do this once.

import { Flex, Box } from 'design';
import { ShimmerBox } from 'design/ShimmerBox';

const DISPLAY_SKELETON_AFTER = 400; // 400 ms
Copy link
Copy Markdown
Contributor Author

@gzdunek gzdunek Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wanted to decrease this, I'll confirm it with Kenny.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I will just change it.

@gzdunek gzdunek removed the request for review from ravicious November 9, 2023 11:11
@avatus
Copy link
Copy Markdown
Contributor

avatus commented Nov 9, 2023

@rudream added another loading skeleton component for list view and realized that the colors in light mode were off. Can we take his updates to the colors and add them here?

Copy link
Copy Markdown
Contributor

@rudream rudream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I applied these changes to the new skeleton loader for list items which I added in this PR: #34381

@gzdunek gzdunek added the no-changelog Indicates that a PR does not require a changelog entry label Nov 10, 2023
@gzdunek
Copy link
Copy Markdown
Contributor Author

gzdunek commented Nov 10, 2023

@rudream added https://github.com/gravitational/teleport/pull/34381for list view and realized that the colors in light mode were off. Can we take his updates to the colors and add them here?

I think we can keep them in his PR, we use the same Shimmer component so after we merge that PR everything will use the updated colors.

@gzdunek
Copy link
Copy Markdown
Contributor Author

gzdunek commented Nov 10, 2023

I refactored the loading skeleton a bit, now it expects an Element prop where we can pass LoadingCard and LoadingListItem. The LoadingSkeletion is now only responsible for the timeout and for rendering the passed Element.

@gzdunek gzdunek enabled auto-merge November 10, 2023 11:21
@gzdunek gzdunek added this pull request to the merge queue Nov 10, 2023
Merged via the queue into master with commit 97c3757 Nov 10, 2023
@gzdunek gzdunek deleted the gzdunek/unified-resources-improvements branch November 10, 2023 11:35
@public-teleport-github-review-bot
Copy link
Copy Markdown

@gzdunek See the table below for backport results.

Branch Result
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a PR does not require a changelog entry size/sm ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants