[Web] Unified Resources: Add skeleton loader to list view#34381
Merged
[Web] Unified Resources: Add skeleton loader to list view#34381
Conversation
3 tasks
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
rudream
added
backport/branch/v14
no-changelog
avatus
reviewed
Nov 9, 2023
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
Check this recent PR that changes the way we setTimeout for the loading skeletons. I think everything in your PR is fine, but we should update it when this other PR goes in to follow the same
rudream
force-pushed
the
yassine/skeleton-loader
branch
from
16bc149 to
6a0d27a
Compare
avatus
approved these changes
Nov 10, 2023
gzdunek
reviewed
Nov 10, 2023
Contributor
gzdunek
left a comment
gzdunek
left a comment
There was a problem hiding this comment.
Looks good, I will take another look today after we resolve conflicts.
rudream
force-pushed
the
yassine/unified-list
branch
2 times, most recently
from
af5e440 to
1ccb682
Compare
rudream
force-pushed
the
yassine/skeleton-loader
branch
2 times, most recently
from
6567518 to
46310fb
Compare
gzdunek
approved these changes
Nov 10, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ibeckermayer
rudream
force-pushed
the
yassine/unified-list
branch
6 times, most recently
from
d0b42dc to
21d6550
Compare
rudream
force-pushed
the
yassine/skeleton-loader
branch
from
46310fb to
ace55d3
Compare
rudream
force-pushed
the
yassine/skeleton-loader
branch
2 times, most recently
from
6961f2f to
12d3503
Compare
add skeleton loader
rudream
force-pushed
the
yassine/skeleton-loader
branch
from
12d3503 to
e7313fe
Compare
Contributor
Author
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Based on #34203
Adds a skeleton loader for the loading state in the unified resources list view.
Note: I also made a tweak to the colors we use in
ShimmerBox.tsx, currently it looks great in dark theme but in light theme I thought the contrast was too low and it was hard to see the effect (comparison below).Will address conflicts and merge once #34384 is merged.
Demo
skeletonloader-dark.mov
skeletonloader-light.mov
Old
ShimmerBoxin light theme:old-lighttheme.mov