Skip to content

Fix floating error box in Unified View #34369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avatus merged 2 commits into from
Nov 9, 2023
Merged

Fix floating error box in Unified View #34369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
298de97
Add test IDs to unified resources components
avatus Nov 8, 2023
3976d13
Add padding to sticky error message in unified view
avatus Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web/packages/shared/components/UnifiedResources/FilterPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,11 @@ export function FilterPanel({
<HoverTooltip
tipContent={<>{selected ? 'Deselect all' : 'Select all'}</>}
>
<StyledCheckbox checked={selected} onChange={selectVisible} />
<StyledCheckbox
checked={selected}
onChange={selectVisible}
data-testid="select_all"
/>
</HoverTooltip>
<FilterTypesMenu
onChange={onKindsChanged}
Expand Down
10 changes: 9 additions & 1 deletion web/packages/shared/components/UnifiedResources/UnifiedResources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,13 @@ export function UnifiedResources(props: UnifiedResourcesProps) {
>
{resourcesFetchAttempt.status === 'failed' && (
<ErrorBox>
<ErrorBoxInternal>
{/* If pinning is hidden, we hide the different tabs to select a view (All resources, pinning).
This causes this error box to cover the search bar. If pinning isn't supported, we push down the
error by 60px to not hide the search bar.
*/}
<ErrorBoxInternal
topPadding={pinning.kind === 'hidden' ? '60px' : '0px'}
>
<Danger>
{resourcesFetchAttempt.statusText}
{/* we don't want them to try another request with BAD REQUEST, it will just fail again. */}
Expand Down Expand Up @@ -378,6 +384,7 @@ export function UnifiedResources(props: UnifiedResourcesProps) {
const $button = (
<ButtonBorder
key={key}
data-testid={key}
textTransform="none"
onClick={() => action(getSelectedResources())}
disabled={disabled}
Expand Down Expand Up @@ -584,6 +591,7 @@ const ErrorBoxInternal = styled(Box)`
position: absolute;
left: 0;
right: 0;
top: ${props => props.topPadding};
margin: ${props => props.theme.space[1]}px 10% 0 10%;
`;

Expand Down