Fix floating error box in Unified View#34369
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
avatus
added
backport-required
backport/branch/v14
no-changelog
avatus
force-pushed
the
avatus/add_test_ids
branch
from
667eff3 to
3976d13
Compare
avatus
requested review from
kimlisa and
rudream
and removed request for
ibeckermayer and
ravicious
kimlisa
approved these changes
Nov 9, 2023
zmb3
approved these changes
Nov 9, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this comment pointed out that when the "tabs" in the unified resource view are hidden (when pinning is hidden) the error box will cover the search.
This will add small conditional to throw some absolute top padding to push the error down and not obscure the search panel. This is a sticky error so I had to push "down" otherwise if the error happened when scrolled farther down, pushing UP would have hidden the error all together
old:
new:
Also, I added some test IDs to help with some tests in https://github.com/gravitational/teleport.e/pull/2514