Fix custom client PivSlot overridden by server settings#34349
Merged
Conversation
Contributor
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
codingllama
approved these changes
Nov 8, 2023
| for _, test := range tests { | ||
| t.Run(test.desc, func(t *testing.T) { | ||
| tc := &TeleportClient{Config: test.tcConfigIn} | ||
| tc.applyAuthSettings(test.settingsIn) |
Contributor
There was a problem hiding this comment.
Any chance we could test this via a public API?
Contributor
Author
There was a problem hiding this comment.
Ideally this would be tested through the Ping method, but I don't have time to add a mock Web apiserver here at the moment.
rosstimothy
approved these changes
Nov 13, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from gabrielcorado
Joerger
added a commit
that referenced
this pull request
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsh --piv-slotwas always ignored in favor of thecap.piv_slot, even when empty.Changelog: Fix
tsh --piv-slotcustom PIV slot setting for Hardware Key Support