Skip to content

[v14] tsh: split large desktop recordings into multiple files#34319

Merged
zmb3 merged 1 commit intobranch/v14from
bot/backport-33784-branch/v14
Nov 15, 2023
Merged

[v14] tsh: split large desktop recordings into multiple files#34319
zmb3 merged 1 commit intobranch/v14from
bot/backport-33784-branch/v14

Conversation

@zmb3
Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 commented Nov 7, 2023

Backport #33784 to branch/v14

AVI files contain 32-bit pointers, which means we cant just add
frames to a single file until the end of time. This change properly
detects when a recording export has reached the maximum size of
an AVI file and splits the recording into multiple files.

Closes #33109
Closes #33110
@github-actions github-actions Bot added backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Nov 7, 2023
@zmb3
Copy link
Copy Markdown
Collaborator Author

zmb3 commented Nov 10, 2023

@gabrielcorado PTAL

@zmb3 zmb3 requested a review from rosstimothy November 14, 2023 15:13
@zmb3 zmb3 added this pull request to the merge queue Nov 14, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 14, 2023
@zmb3 zmb3 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into branch/v14 with commit 7806aad Nov 15, 2023
@zmb3 zmb3 deleted the bot/backport-33784-branch/v14 branch November 15, 2023 09:27
This was referenced Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants