Skip to content

splits exported desktop recordings into multiple files if required#33110

Closed
stevenGravy wants to merge 2 commits intomasterfrom
stevenGravy/splitdesktopexport
Closed

splits exported desktop recordings into multiple files if required#33110
stevenGravy wants to merge 2 commits intomasterfrom
stevenGravy/splitdesktopexport

Conversation

@stevenGravy
Copy link
Copy Markdown
Contributor

@stevenGravy stevenGravy commented Oct 7, 2023

fixes #33109

@stevenGravy stevenGravy requested a review from zmb3 October 7, 2023 16:27
@stevenGravy stevenGravy enabled auto-merge October 7, 2023 16:28
@github-actions github-actions Bot requested a review from jimbishopp October 7, 2023 16:28
@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Oct 7, 2023
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Oct 7, 2023

Good find Steven. Overall I like the approach but I'd like to clean this up a little bit if that's okay with you.

@stevenGravy
Copy link
Copy Markdown
Contributor Author

stevenGravy commented Oct 7, 2023

Good find Steven. Overall I like the approach but I'd like to clean this up a little bit if that's okay with you.

Sure. Given that it takes some time to generate we may want to output file info as they go vs at the end. Please suggest changes or update as you see fit.

@zmb3 zmb3 mentioned this pull request Oct 20, 2023
Merged
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Oct 20, 2023

I opened #33784 as an alternative to this. Instead of imposing an artificial limit on filesize and doing a bunch of stats, we break up the recording only when necessary.

auto-merge was automatically disabled October 20, 2023 23:06

Pull request was closed

zmb3 added a commit that referenced this pull request Oct 20, 2023
@zmb3
tsh: split large desktop recordings into multiple files
b150775 
AVI files contain 32-bit pointers, which means we cant just add
frames to a single file until the end of time. This change properly
detects when a recording export has reached the maximum size of
an AVI file and splits the recording into multiple files.

Closes #33109
Closes #33110
github-merge-queue Bot pushed a commit that referenced this pull request Nov 7, 2023
@zmb3
tsh: split large desktop recordings into multiple files (#33784)
fe40a22 
AVI files contain 32-bit pointers, which means we cant just add
frames to a single file until the end of time. This change properly
detects when a recording export has reached the maximum size of
an AVI file and splits the recording into multiple files.

Closes #33109
Closes #33110
github-actions Bot pushed a commit that referenced this pull request Nov 7, 2023
@zmb3
tsh: split large desktop recordings into multiple files
09cf854 
AVI files contain 32-bit pointers, which means we cant just add
frames to a single file until the end of time. This change properly
detects when a recording export has reached the maximum size of
an AVI file and splits the recording into multiple files.

Closes #33109
Closes #33110
github-actions Bot pushed a commit that referenced this pull request Nov 7, 2023
@zmb3
tsh: split large desktop recordings into multiple files
7e2e4f1 
AVI files contain 32-bit pointers, which means we cant just add
frames to a single file until the end of time. This change properly
detects when a recording export has reached the maximum size of
an AVI file and splits the recording into multiple files.

Closes #33109
Closes #33110
github-merge-queue Bot pushed a commit that referenced this pull request Nov 14, 2023
@zmb3
tsh: split large desktop recordings into multiple files (#34320)
ad9fa8f 
AVI files contain 32-bit pointers, which means we cant just add
frames to a single file until the end of time. This change properly
detects when a recording export has reached the maximum size of
an AVI file and splits the recording into multiple files.

Closes #33109
Closes #33110
github-merge-queue Bot pushed a commit that referenced this pull request Nov 15, 2023
@zmb3
tsh: split large desktop recordings into multiple files (#34319)
7806aad 
AVI files contain 32-bit pointers, which means we cant just add
frames to a single file until the end of time. This change properly
detects when a recording export has reached the maximum size of
an AVI file and splits the recording into multiple files.

Closes #33109
Closes #33110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmb3 zmb3 Awaiting requested review from zmb3

@jimbishopp jimbishopp Awaiting requested review from jimbishopp

Assignees

No one assigned

Labels

size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Desktop access export cannot export larger then 4gb AVI content

2 participants

@stevenGravy @zmb3