[v14] Enable Connect My Computer Discover tile & deep links in Connect#33688
Merged
ravicious merged 2 commits intobranch/v14from Nov 13, 2023
Merged
[v14] Enable Connect My Computer Discover tile & deep links in Connect#33688ravicious merged 2 commits intobranch/v14from
ravicious merged 2 commits intobranch/v14from
Conversation
ravicious
force-pushed
the
ravicious/v14/enable-deep-link-support
branch
from
a1a0748 to
5c87bed
Compare
ravicious
changed the title
ravicious
force-pushed
the
ravicious/v14/enable-deep-link-support
branch
from
5c87bed to
abbfce9
Compare
ravicious
changed the base branch from
branch/v14
to
bot/backport-34078-branch/v14
This reverts commit 26f56bd.
ravicious
force-pushed
the
ravicious/v14/enable-deep-link-support
branch
from
abbfce9 to
09b80eb
Compare
ravicious
changed the title
Member
Author
|
@ryanclark @gzdunek Reminder about the reviews for this backport, I'd like to be able to merge it on Friday or Monday! This acts as sort of a "feature flag" PR that will enable both deep link support in Connect & the Discover tile for Connect My Computer. |
gzdunek
approved these changes
Nov 8, 2023
ryanclark
approved these changes
Nov 8, 2023
ravicious
added
the
no-changelog
Merged
Merged
ravicious
removed
the
no-changelog
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #33637 (partially). Do not merge before #32185 release (slated for v14.2).
As discussed in #33684 (comment), these changes will make it so that the packaged build of Connect will be recognized by the OS as a valid handler for
teleport://links.We should merge it only before the launch of the Connect My Computer Discover tile (slated for v14.2) so that previous builds of Connect are not recognized as handlers for
teleport://.Changelog: Added a guided flow for joining your computer to the Teleport cluster using Teleport Connect; find it in the Web UI under Enroll New Resource -> Connect My Computer (available only for local users, see the prerequisites at https://goteleport.com/docs/connect-your-client/teleport-connect/#connect-my-computer)