[v14] Configure Connect to intercept deep link clicks#33684
Merged
ravicious merged 3 commits intobranch/v14from Oct 19, 2023
Merged
[v14] Configure Connect to intercept deep link clicks#33684ravicious merged 3 commits intobranch/v14from
ravicious merged 3 commits intobranch/v14from
Conversation
Member
Author
|
Actually, maybe I should add a feature flag first before I merge this. Without the feature flag, if this goes out in 14.1.1 and then we launch the Discover tile in 14.2 and someone with 14.1.1 will click on it, they'll complain that the app gets focus but nothing happens. |
Member
Author
|
The feature flag won't accomplish much actually. Instead, I'm going to move electron-builder config changes to a separate v14 PR. Those changes make the OS recognize that Connect has support for |
ryanclark
approved these changes
Oct 19, 2023
ravicious
force-pushed
the
bot/backport-33637-branch/v14
branch
from
93679af to
5646db3
Compare
gzdunek
approved these changes
Oct 19, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #33637 to branch/v14 (partially).
Changes to electron-builder config which actually make the OS recognize Connect as a handler for
teleport://links have been extracted to #33688. This way #33688 can act as a sort of feature flag which will disable deep link support until merged.