Skip to content

Add user_certificates_generated prometheus metric#33413

Merged
Joerger merged 1 commit intomasterfrom
joerger/hardware-key-prometheus
Oct 13, 2023
Merged

Add user_certificates_generated prometheus metric#33413
Joerger merged 1 commit intomasterfrom
joerger/hardware-key-prometheus

Conversation

@Joerger
Copy link
Copy Markdown
Contributor

@Joerger Joerger commented Oct 12, 2023

This is needed for Hardware Key support product analytics:

> curl -s http://127.0.0.1:3000/metrics | grep user_certificates_generated
# HELP teleport_user_certificates_generated Tracks the number of user certificates generated
# TYPE teleport_user_certificates_generated counter
teleport_user_certificates_generated{private_key_policy="hardware_key"} 2
teleport_user_certificates_generated{private_key_policy="hardware_key_touch"} 1
teleport_user_certificates_generated{private_key_policy="none"} 1

@Joerger Joerger requested a review from r0mant October 12, 2023 20:08
@Joerger Joerger changed the title Add user certificates generated prometheus metric Add user_certificates_generated prometheus metric Oct 12, 2023
@Joerger Joerger mentioned this pull request Oct 12, 2023
Closed
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Oct 13, 2023

Looks fine but product analytics should go to PostHog, right? Prometheus is for performance and monitoring data.

@Joerger Joerger added this pull request to the merge queue Oct 13, 2023
Merged via the queue into master with commit 32be8ec Oct 13, 2023
@Joerger Joerger deleted the joerger/hardware-key-prometheus branch October 13, 2023 19:00
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented Oct 13, 2023

@Joerger See the table below for backport results.

Branch Result
branch/v14 Create PR

@Joerger Joerger mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@probakowski probakowski probakowski approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees

No one assigned

Labels

size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Joerger @zmb3 @probakowski