Add a duration for starting notifications to access lists.#33373
Merged
Add a duration for starting notifications to access lists.#33373
Conversation
A configurable duration has been added to access lists that will determine when notifications will start being given for access lists that are nearing to the next audit date. All this does is add the field, it does not yet specify the exact notification behavior.
r0mant
approved these changes
Oct 12, 2023
fspmarshall
approved these changes
Oct 13, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from xacrimon
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced Oct 13, 2023
camscale
added a commit
to gravitational/teleport-plugins
that referenced
this pull request
Oct 19, 2023
Add a custom type for `AccessList.spec.audit.notifications.start` as `Duration` so we can generate correct code for the Notifications message. This field was added in PR gravitational/teleport#33373. Link: gravitational/teleport#33373
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A configurable duration has been added to access lists that will determine when notifications will start being given for access lists that are nearing to the next audit date. All this does is add the field, it does not yet specify the exact notification behavior.