This repository was archived by the owner on Jun 4, 2024. It is now read-only.
terraform: Add notifications.start to accesslist custom_types#958
Closed
terraform: Add notifications.start to accesslist custom_types#958
Conversation
Add a custom type for `AccessList.spec.audit.notifications.start` as `Duration` so we can generate correct code for the Notifications message. This field was added in PR gravitational/teleport#33373. Link: gravitational/teleport#33373
camscale
requested review from
Joerger,
fheinecke,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
marcoandredinis
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a custom type for
AccessList.spec.audit.notifications.startasDurationso we can generate correct code for the Notificationsmessage.
This field was added in PR gravitational/teleport#33373.
Link: gravitational/teleport#33373