[v12] Fix tsh kube credentials when root cluster roles don't allow Kube access#33227
Merged
tigrato merged 1 commit intobranch/v12from Oct 11, 2023
Merged
[v12] Fix tsh kube credentials when root cluster roles don't allow Kube access#33227tigrato merged 1 commit intobranch/v12from
tsh kube credentials when root cluster roles don't allow Kube access#33227tigrato merged 1 commit intobranch/v12from
Conversation
…ccess (#33014) * Fix `tsh kube credentials` when root cluster roles don't allow Kube access This PR fixes an edge case where an error message is printed to the users without proper knowledge of the role mappings between root and leaf clusters. The user certificates include the `kubernetes_users` and `kubernetes_groups` allowed in the root cluster but nothing prevents the access to be sucessfull if the leaf cluster roles after the mapping introduce the kubernetes principals. This PR prevents tsh from failing when generating certificates for leaf Kubernetes clusters. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update tool/tsh/common/kube.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> * add check to tsh proxy --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
github-actions
Bot
added
backport
size/sm
tsh
r0mant
approved these changes
Oct 10, 2023
espadolini
approved these changes
Oct 11, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from smallinsky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #33014 to branch/v12