Fix tsh kube credentials when root cluster roles don't allow Kube access#33014
Merged
Fix tsh kube credentials when root cluster roles don't allow Kube access#33014
tsh kube credentials when root cluster roles don't allow Kube access#33014Conversation
…ccess This PR fixes an edge case where an error message is printed to the users without proper knowledge of the role mappings between root and leaf clusters. The user certificates include the `kubernetes_users` and `kubernetes_groups` allowed in the root cluster but nothing prevents the access to be sucessfull if the leaf cluster roles after the mapping introduce the kubernetes principals. This PR prevents tsh from failing when generating certificates for leaf Kubernetes clusters. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
github-actions
Bot
added
size/sm
tsh
espadolini
approved these changes
Oct 5, 2023
Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
tigrato
force-pushed
the
tigrato/fix-tsh-remote-clusters
branch
3 times, most recently
from
0b30a4c to
7ab0c80
Compare
tigrato
force-pushed
the
tigrato/fix-tsh-remote-clusters
branch
from
7ab0c80 to
756ba42
Compare
smallinsky
approved these changes
Oct 10, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from tcsc
This was referenced Oct 10, 2023
tigrato
added a commit
that referenced
this pull request
Oct 10, 2023
…ccess (#33014) * Fix `tsh kube credentials` when root cluster roles don't allow Kube access This PR fixes an edge case where an error message is printed to the users without proper knowledge of the role mappings between root and leaf clusters. The user certificates include the `kubernetes_users` and `kubernetes_groups` allowed in the root cluster but nothing prevents the access to be sucessfull if the leaf cluster roles after the mapping introduce the kubernetes principals. This PR prevents tsh from failing when generating certificates for leaf Kubernetes clusters. Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> * Update tool/tsh/common/kube.go Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com> * add check to tsh proxy --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ccess (#33014) (#33227) * Fix `tsh kube credentials` when root cluster roles don't allow Kube access This PR fixes an edge case where an error message is printed to the users without proper knowledge of the role mappings between root and leaf clusters. The user certificates include the `kubernetes_users` and `kubernetes_groups` allowed in the root cluster but nothing prevents the access to be sucessfull if the leaf cluster roles after the mapping introduce the kubernetes principals. This PR prevents tsh from failing when generating certificates for leaf Kubernetes clusters. * Update tool/tsh/common/kube.go * add check to tsh proxy --------- Signed-off-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case where an error message is printed to the users without proper knowledge of the role mappings between root and leaf clusters.
The user certificates include the
kubernetes_usersandkubernetes_groupsallowed in the root cluster. Still, nothing prevents the access from being successful if the leaf cluster roles after mapping introduce the Kubernetes principals.This PR prevents tsh from failing when generating certificates for leaf Kubernetes clusters.