[v13] Track user connections across clusters#32996
Merged
rosstimothy merged 4 commits intobranch/v13from Oct 5, 2023
Merged
Conversation
rosstimothy
force-pushed
the
tross/backport-32688/v13
branch
from
49deb97 to
c4f660f
Compare
Backports part of #28357 to branch/v13
Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605.
rosstimothy
force-pushed
the
tross/backport-32688/v13
branch
from
c4f660f to
de4b81b
Compare
github-actions
Bot
added
database-access
github-actions
Bot
requested review from
espadolini,
fspmarshall and
gabrielcorado
espadolini
approved these changes
Oct 5, 2023
gabrielcorado
approved these changes
Oct 5, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605.
#32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
fspmarshall
approved these changes
Oct 5, 2023
espadolini
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #32688 and #33035 to branch/v13
In order to prevent circular imports this also backports a portion of #28357