Track user connections across clusters#32688
Merged
rosstimothy merged 1 commit intomasterfrom Oct 4, 2023
Merged
Conversation
fspmarshall
reviewed
Sep 27, 2023
rosstimothy
force-pushed
the
tross/track_connections_across_clusters
branch
from
1a52cb3 to
260e43a
Compare
espadolini
reviewed
Sep 28, 2023
espadolini
reviewed
Sep 28, 2023
espadolini
approved these changes
Sep 28, 2023
Contributor
Author
|
Friendly ping @gabrielcorado @fspmarshall |
gabrielcorado
approved these changes
Oct 4, 2023
Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605.
rosstimothy
force-pushed
the
tross/track_connections_across_clusters
branch
from
59baf3f to
2320a4f
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Oct 5, 2023
Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605.
Contributor
Author
|
Also closes #17152 |
rosstimothy
added a commit
that referenced
this pull request
Oct 5, 2023
Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605.
rosstimothy
added a commit
that referenced
this pull request
Oct 5, 2023
#32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
rosstimothy
added a commit
that referenced
this pull request
Oct 5, 2023
Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605.
rosstimothy
added a commit
that referenced
this pull request
Oct 5, 2023
#32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
rosstimothy
added a commit
that referenced
this pull request
Oct 5, 2023
#32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
#32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
#32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Break client facing types out of reversetunnel package Backports part of #28357 to branch/v13 * Track user connections across clusters (#32688) Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605. * Track connections to direct dial nodes across clusters #32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Break client facing types out of reversetunnel package Backports part of #28357 to branch/v13 * Track user connections across clusters (#32688) Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605. * Track user connections across clusters (#32688) Ensure that `proxy_ssh_sessions_total` is incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root. Fixes #32605. * Track connections to direct dial nodes across clusters #32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
#32688 added support for tracking connections to sessions via a reverse tunnel node but failed to account for sessions to direct dial nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that
proxy_ssh_sessions_totalis incremented in both the root and the leaf cluster if a session to a node in the leaf cluster is established through the root cluster. This now also prevents leaf clusters from terminating during a graceful shutdown if there is an active connection that was created from the root.Fixes #32605.