Skip to content

Yarn replacement version bumps #32982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jentfoo merged 1 commit into from
Oct 5, 2023
Merged

Yarn replacement version bumps #32982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@ravicious ravicious Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not address CVEs, and thus is not planned to be backported.

I think we should backport it. minimist and @types/react are rather minor, but Webpack is used to build Connect. Backporting doesn't cost us much and I'd rather have the same Webpack version across all supported branches.

Otherwise we risk that something that works on master breaks after backporting because of a quirk between Webpack versions.

Copy link
Copy Markdown
Contributor Author

@jentfoo jentfoo Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, I have no concern with backporting I just wanted to highlight it was not required. Do you only want to backport to v14, or should I backport further than that?

Copy link
Copy Markdown
Member

@ravicious ravicious Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v14–v12 please! 🙏

Copy link
Copy Markdown
Contributor Author

@jentfoo jentfoo Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v12 would incur a more significant version jump and it looked to introduce build failures. But backports for v14 and v13 are up.

Copy link
Copy Markdown
Contributor

@gzdunek gzdunek Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jentfoo but did you see any errors? I just tried backporting to v12 and yarn storybook, yarn start-term and yarn build-term, yarn build-ui and yarn start-teleport (Web UI uses webpack on v12) seem to work fine.

Copy link
Copy Markdown
Contributor Author

@jentfoo jentfoo Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gzdunek I was seeing a build failure with make full-ent on v12, but had no issues on v13 or v14

Copy link
Copy Markdown
Contributor

@gzdunek gzdunek Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to create a backport branch anyway? I can take a look at the issue, it seems weird that building OSS went fine, while Enterprise not.

Copy link
Copy Markdown
Contributor Author

@jentfoo jentfoo Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @gzdunek. I was able to circle back to this and tried to reproduce the failure, however the build appears to work now. I am unsure what my prior issue with v12 is, but I am guessing I failed to sync the e reference correctly.

I have a new PR up to include these updates into v12: #33426

Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
"private": true,
"resolutions": {
"react": "16.14.0",
"**/minimist": "^1.2.5",
"**/@types/react": "^16.8.19",
"**/minimist": "^1.2.8",
"**/@types/react": "^16.9.49",
"**/trim": "0.0.3",
"webpack": "^5.76.2",
"webpack": "^5.88.2",
"x-default-browser": "^0.5.2"
},
"devDependencies": {
Expand Down
Loading