Conversation
Updates minor versions for `minimist` `@types/react` and `webpack`
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
yarn storybook, yarn start-term and yarn build-term all work correctly.
There was a problem hiding this comment.
This does not address CVEs, and thus is not planned to be backported.
I think we should backport it. minimist and @types/react are rather minor, but Webpack is used to build Connect. Backporting doesn't cost us much and I'd rather have the same Webpack version across all supported branches.
Otherwise we risk that something that works on master breaks after backporting because of a quirk between Webpack versions.
There was a problem hiding this comment.
Sounds good to me, I have no concern with backporting I just wanted to highlight it was not required. Do you only want to backport to v14, or should I backport further than that?
There was a problem hiding this comment.
v12 would incur a more significant version jump and it looked to introduce build failures. But backports for v14 and v13 are up.
There was a problem hiding this comment.
@jentfoo but did you see any errors? I just tried backporting to v12 and yarn storybook, yarn start-term and yarn build-term, yarn build-ui and yarn start-teleport (Web UI uses webpack on v12) seem to work fine.
There was a problem hiding this comment.
@gzdunek I was seeing a build failure with make full-ent on v12, but had no issues on v13 or v14
There was a problem hiding this comment.
Would you like to create a backport branch anyway? I can take a look at the issue, it seems weird that building OSS went fine, while Enterprise not.
There was a problem hiding this comment.
Sorry for the delay @gzdunek. I was able to circle back to this and tried to reproduce the failure, however the build appears to work now. I am unsure what my prior issue with v12 is, but I am guessing I failed to sync the e reference correctly.
I have a new PR up to include these updates into v12: #33426
public-teleport-github-review-bot
Bot
removed request for
gzdunek,
klizhentas and
ryanclark
Updates minor versions for `minimist` `@types/react` and `webpack`
Updates minor versions for `minimist` `@types/react` and `webpack`
4 participants
Updates minor versions for
minimist@types/reactandwebpack. This does not address CVEs, and thus is not planned to be backported.