[v12] fix: Let users without a useable device issue register challenges#32669
Merged
codingllama merged 3 commits intobranch/v12from Sep 28, 2023
Merged
[v12] fix: Let users without a useable device issue register challenges#32669codingllama merged 3 commits intobranch/v12from
codingllama merged 3 commits intobranch/v12from
Conversation
kimlisa
approved these changes
Sep 28, 2023
Tener
approved these changes
Sep 28, 2023
Contributor
Tener
left a comment
Tener
left a comment
There was a problem hiding this comment.
I believe this is the case, but I wanted to confirm: this is a backwards compatible change for v12 clients, yes?
Contributor
Author
|
@Tener yes, it should be alright. It's mainly moving logic and adding the bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #32430 to branch/v12.
Cherry-pick of parts of #32271 (validateMFAAuthResponseForRegister function) and #32428, with a couple of manual changes due to branch drift.
Count devices according to the cluster settings, so users without a useable device can still register new MFA devices (via privilege tokens).
This is a long-standing corner case of privilege tokens. tsh registrations not affected.
Changelog: Fix a corner case of privilege tokens where MFA devices disabled by cluster settings were still counted against the user.