fix: Let users without a useable device issue register challenges#32428
Merged
codingllama merged 2 commits intomasterfrom Sep 26, 2023
Merged
fix: Let users without a useable device issue register challenges#32428codingllama merged 2 commits intomasterfrom
codingllama merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
This is worth backporting in some form, so I've added the labels to remind me. I think if I change the RPC calls to CreatePrivilegeToken I might be able to keep the test. |
Contributor
Author
|
Draft "backport" here: #32430. I'll hold it until this one gets through review, so I can make sure the code matches as much as possible. |
rosstimothy
approved these changes
Sep 25, 2023
Contributor
Author
kimlisa
approved these changes
Sep 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from Tener
Tener
approved these changes
Sep 26, 2023
This was referenced Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count devices according to the cluster settings, so users without a useable device can still register new MFA devices.
Fixes bug brought to light by #32271 (and subsequent PRs). This is a long-standing corner case of privilege tokens.
tshregistrations in current release branches not affected (including v14).#20343
Changelog: Fix a corner case of privilege tokens where MFA devices disabled by cluster settings were still counted against the user.