[v12] Add support for Protobuf Enums into Operator CRDs#32559
Merged
tigrato merged 2 commits intobranch/v12from Sep 26, 2023
Merged
[v12] Add support for Protobuf Enums into Operator CRDs#32559tigrato merged 2 commits intobranch/v12from
tigrato merged 2 commits intobranch/v12from
Conversation
* Add support for Protobuf Enums into Operator CRDs This PR marks the Teleport enum fields as integer or string values. The integer option is to ensure we are backwards compatibile with previously installed CRDs. Users can now represent their roles in Kubernetes custom resources and refer enum fields as strings while their protobuf wire type is int32. Fixes #29686 * add tests * fix unit test
github-actions
Bot
requested review from
hugoShaka,
marcoandredinis and
r0mant
Comment on lines
+1924
to
+1930
| <<<<<<< HEAD:operator/crdgen/testdata/golden/resources.teleport.dev_roles.yaml | ||
| ======= | ||
| create_host_user_mode: | ||
| description: CreateHostUserMode allows users to be automatically | ||
| created on a host when not set to off | ||
| x-kubernetes-int-or-string: true | ||
| >>>>>>> 9a556d8ab1 (Add support for Protobuf Enums into Operator CRDs (#32469)):integrations/operator/crdgen/testdata/golden/resources.teleport.dev_roles.yaml |
Contributor
Author
There was a problem hiding this comment.
Forgot to update the snapshots 🦥
marcoandredinis
approved these changes
Sep 26, 2023
r0mant
approved these changes
Sep 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from hugoShaka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #32469 to branch/v12