Add support for Protobuf Enums into Operator CRDs#32469
Merged
Conversation
This PR marks the Teleport enum fields as integer or string values. The integer option is to ensure we are backwards compatibile with previously installed CRDs. Users can now represent their roles in Kubernetes custom resources and refer enum fields as strings while their protobuf wire type is int32. Fixes #29686
tigrato
force-pushed
the
tigrato/crds-emnums
branch
from
e535665 to
fd0d45f
Compare
r0mant
approved these changes
Sep 25, 2023
hugoShaka
approved these changes
Sep 25, 2023
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis and
webvictim
marcoandredinis
approved these changes
Sep 26, 2023
This was referenced Sep 26, 2023
tigrato
added a commit
that referenced
this pull request
Sep 26, 2023
* Add support for Protobuf Enums into Operator CRDs This PR marks the Teleport enum fields as integer or string values. The integer option is to ensure we are backwards compatibile with previously installed CRDs. Users can now represent their roles in Kubernetes custom resources and refer enum fields as strings while their protobuf wire type is int32. Fixes #29686 * add tests * fix unit test
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Add support for Protobuf Enums into Operator CRDs (#32469) * Add support for Protobuf Enums into Operator CRDs This PR marks the Teleport enum fields as integer or string values. The integer option is to ensure we are backwards compatibile with previously installed CRDs. Users can now represent their roles in Kubernetes custom resources and refer enum fields as strings while their protobuf wire type is int32. Fixes #29686 * add tests * fix unit test * fix conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR marks the Teleport enum fields as integer or string values. The integer option is to ensure we are backwards compatibile with previously installed CRDs.
Users can now represent their roles in Kubernetes custom resources and refer enum fields as strings while their protobuf wire type is int32.
Fixes #29686