DiscoveryConfig: add service with rbac support#32371
Merged
marcoandredinis merged 2 commits intomasterfrom Sep 27, 2023
Merged
Conversation
marcoandredinis
added
discover
This was referenced Sep 22, 2023
marcoandredinis
force-pushed
the
marco/discovery_config_service_client
branch
from
b487779 to
21137b6
Compare
Base automatically changed from
marco/discovery_config_service_client
to
master
September 26, 2023 14:23
marcoandredinis
force-pushed
the
marco/discovery_config_service_with_rbac
branch
from
4bd0512 to
09ada06
Compare
lxea
approved these changes
Sep 27, 2023
nklaassen
reviewed
Sep 27, 2023
Comment on lines
+60
to
+62
| if s.Logger == nil { | ||
| s.Logger = logrus.WithField(trace.Component, "DiscoveryConfig.service") | ||
| } | ||
|
|
||
| if s.Logger == nil { | ||
| s.Logger = logrus.New().WithField(trace.Component, "discoveryconfig_crud_service") | ||
| } |
Contributor
There was a problem hiding this comment.
pick one :) looking at all the Component* in constants.go I might name it discoveryconfig:service
Contributor
Author
There was a problem hiding this comment.
I'll use "discoveryconfig_crud_service"
Seems to be used in other places like access_list, okta, and user_login_state
This PR adds the DiscoveryConfig service protected by RBAC rules. A PR will follow that uses this service to expose the service in the gRPC server.
marcoandredinis
force-pushed
the
marco/discovery_config_service_with_rbac
branch
from
09ada06 to
aa4b7a9
Compare
nklaassen
approved these changes
Sep 27, 2023
marcoandredinis
deleted the
marco/discovery_config_service_with_rbac
branch
|
@marcoandredinis See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the DiscoveryConfig service protected by RBAC rules.
A PR will follow that uses this service to expose the service in the gRPC server.