DiscoveryConfig: add service and client#32328
Merged
marcoandredinis merged 1 commit intomasterfrom Sep 26, 2023
Merged
Conversation
marcoandredinis
changed the base branch from
marco/discovery_matchers_checkandset
to
master
marcoandredinis
force-pushed
the
marco/discovery_config_service_client
branch
from
8a0f63b to
b487779
Compare
marcoandredinis
added
discover
Contributor
Author
|
@probakowski @Tener Can you please take a look? |
Contributor
Sorry for the delay.
Do you have the follow-up PR handy? |
Contributor
Author
Tener
approved these changes
Sep 26, 2023
Contributor
Tener
left a comment
Tener
left a comment
There was a problem hiding this comment.
I wish we could add new resource types without so much boilerplate.
probakowski
approved these changes
Sep 26, 2023
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
Sorry for the delay, LGTM
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This PR adds a Service and Client implementation for the DiscoveryConfig resource. It does not add any initialization/usage to keep the PR small.
marcoandredinis
force-pushed
the
marco/discovery_config_service_client
branch
from
b487779 to
21137b6
Compare
|
@marcoandredinis See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Service and Client implementation for the DiscoveryConfig resource.
It does not add any initialization/usage to keep the PR small.