[v12] Ensure that DNS errors in desktop discovery fail fast#31033
Merged
zmb3 merged 1 commit intobranch/v12from Aug 25, 2023
Merged
[v12] Ensure that DNS errors in desktop discovery fail fast#31033zmb3 merged 1 commit intobranch/v12from
zmb3 merged 1 commit intobranch/v12from
Conversation
In #30277 we made the discovery process make two DNS queries in parallel. There was an error in this logic - since we don't write to the channel on error, if both queries fail we end up waiting a full 5 seconds even if the failures occur much quicker than that.
github-actions
Bot
requested review from
Tener,
camscale,
ibeckermayer and
r0mant
ibeckermayer
approved these changes
Aug 25, 2023
r0mant
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #30979 to branch/v12