Ensure that DNS errors in desktop discovery fail fast#30979
Merged
Conversation
zmb3
commented
Aug 24, 2023
zmb3
force-pushed
the
zmb3/discovery-fix
branch
from
f52727f to
811d615
Compare
Tener
approved these changes
Aug 24, 2023
In #30277 we made the discovery process make two DNS queries in parallel. There was an error in this logic - since we don't write to the channel on error, if both queries fail we end up waiting a full 5 seconds even if the failures occur much quicker than that.
zmb3
force-pushed
the
zmb3/discovery-fix
branch
from
811d615 to
483f5a2
Compare
camscale
approved these changes
Aug 25, 2023
r0mant
approved these changes
Aug 25, 2023
This was referenced Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #30277 we made the discovery process make two DNS queries in parallel. There was an error in this logic - since we don't write to the channel on error, if both queries fail we end up waiting a full 5 seconds even if the failures occur much quicker than that.
Changelog: Fix a regression with desktop discovery that could cause desktops to expire in environments with large numbers of desktops.