[v12] - Additional safety with X-Forwarded-Host handling (#30980)#31026
Merged
jentfoo merged 1 commit intobranch/v12from Aug 25, 2023
Merged
[v12] - Additional safety with X-Forwarded-Host handling (#30980)#31026jentfoo merged 1 commit intobranch/v12from
X-Forwarded-Host handling (#30980)#31026jentfoo merged 1 commit intobranch/v12from
Conversation
* Additional safety with `X-Forwarded-Host` handling This adds `utils.GetSingleHeader` as a common way to make sure that additional headers are not being inserted into the request. We use this in the `aws`, `azure`, and `gcp` handler as part of verifying the source of the request. In addition `alpnproxy/local_proxy.go` contains a fix where an invalid `Host` header can allow an arbitrary `X-Forwarded-Host` value to pass through unchanged. * Apply PR feedback around error type and testing
jentfoo
requested review from
Tener,
codingllama,
greedy52,
rosstimothy and
zmb3
rosstimothy
approved these changes
Aug 25, 2023
greedy52
approved these changes
Aug 25, 2023
public-teleport-github-review-bot
Bot
removed request for
Tener,
codingllama and
zmb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v12 backport of PR #30980