Additional safety with X-Forwarded-Host handling#30980
Merged
Conversation
jentfoo
requested review from
Tener,
codingllama,
greedy52,
rosstimothy and
zmb3
zmb3
approved these changes
Aug 24, 2023
This adds `utils.GetSingleHeader` as a common way to make sure that additional headers are not being inserted into the request. We use this in the `aws`, `azure`, and `gcp` handler as part of verifying the source of the request. In addition `alpnproxy/local_proxy.go` contains a fix where an invalid `Host` header can allow an arbitrary `X-Forwarded-Host` value to pass through unchanged.
jentfoo
force-pushed
the
jent/forwarded-host-safety
branch
from
eae2f5f to
9af9755
Compare
greedy52
approved these changes
Aug 24, 2023
public-teleport-github-review-bot
Bot
removed request for
Tener,
codingllama,
jimbishopp and
rosstimothy
rosstimothy
approved these changes
Aug 24, 2023
jentfoo
added a commit
that referenced
this pull request
Aug 25, 2023
* Additional safety with `X-Forwarded-Host` handling This adds `utils.GetSingleHeader` as a common way to make sure that additional headers are not being inserted into the request. We use this in the `aws`, `azure`, and `gcp` handler as part of verifying the source of the request. In addition `alpnproxy/local_proxy.go` contains a fix where an invalid `Host` header can allow an arbitrary `X-Forwarded-Host` value to pass through unchanged. * Apply PR feedback around error type and testing
jentfoo
added a commit
that referenced
this pull request
Aug 25, 2023
* Additional safety with `X-Forwarded-Host` handling This adds `utils.GetSingleHeader` as a common way to make sure that additional headers are not being inserted into the request. We use this in the `aws`, `azure`, and `gcp` handler as part of verifying the source of the request. In addition `alpnproxy/local_proxy.go` contains a fix where an invalid `Host` header can allow an arbitrary `X-Forwarded-Host` value to pass through unchanged. * Apply PR feedback around error type and testing
This was referenced Aug 25, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* Additional safety with `X-Forwarded-Host` handling This adds `utils.GetSingleHeader` as a common way to make sure that additional headers are not being inserted into the request. We use this in the `aws`, `azure`, and `gcp` handler as part of verifying the source of the request. In addition `alpnproxy/local_proxy.go` contains a fix where an invalid `Host` header can allow an arbitrary `X-Forwarded-Host` value to pass through unchanged. * Apply PR feedback around error type and testing
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* Additional safety with `X-Forwarded-Host` handling This adds `utils.GetSingleHeader` as a common way to make sure that additional headers are not being inserted into the request. We use this in the `aws`, `azure`, and `gcp` handler as part of verifying the source of the request. In addition `alpnproxy/local_proxy.go` contains a fix where an invalid `Host` header can allow an arbitrary `X-Forwarded-Host` value to pass through unchanged. * Apply PR feedback around error type and testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
utils.GetSingleHeaderas a common way to make sure that additional headers are not being inserted into the request. We use this in theaws,azure, andgcphandler as part of verifying the source of the request.In addition
alpnproxy/local_proxy.gocontains a fix where an invalidHostheader can allow an arbitraryX-Forwarded-Hostvalue to pass through unchanged.This PR fixes low severity issue: https://github.com/gravitational/teleport-private/issues/922