[v12] Review Requests: prevent reviews after request is resolved#30689
Merged
marcoandredinis merged 4 commits intobranch/v12from Aug 18, 2023
Merged
[v12] Review Requests: prevent reviews after request is resolved#30689marcoandredinis merged 4 commits intobranch/v12from
marcoandredinis merged 4 commits intobranch/v12from
Conversation
Return an error when trying to approve or deny a request after it was resolved.
rosstimothy
approved these changes
Aug 18, 2023
r0mant
approved these changes
Aug 18, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from greedy52
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #30673 to branch/v12