Review Requests: prevent reviews after request is resolved#30673
Merged
marcoandredinis merged 4 commits intomasterfrom Aug 18, 2023
Merged
Review Requests: prevent reviews after request is resolved#30673marcoandredinis merged 4 commits intomasterfrom
marcoandredinis merged 4 commits intomasterfrom
Conversation
rosstimothy
reviewed
Aug 18, 2023
marcoandredinis
force-pushed
the
marco/review_request_handle_resolved
branch
from
48e4b37 to
73d6cde
Compare
rosstimothy
approved these changes
Aug 18, 2023
Collaborator
|
Does this fix #5622? |
Contributor
Author
I was not aware of that issue |
greedy52
approved these changes
Aug 18, 2023
r0mant
approved these changes
Aug 18, 2023
Return an error when trying to approve or deny a request after it was resolved.
marcoandredinis
force-pushed
the
marco/review_request_handle_resolved
branch
from
6ca5000 to
2fd1f96
Compare
|
@marcoandredinis See the table below for backport results.
|
This was referenced Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return an error when trying to approve or deny a request after it was resolved.
Demo
Scenario:
Screen from UserB:
