update tsh db env/config ux#30530
Merged
GavinFrazar merged 1 commit intomasterfrom Aug 16, 2023
Merged
Conversation
smallinsky
approved these changes
Aug 16, 2023
greedy52
approved these changes
Aug 16, 2023
Base automatically changed from
gavinfrazar/fix-tsh-db-connect-prefix
to
master
August 16, 2023 16:27
* when a given db name doesn't match any active cert fully, call ListDatabases API and check if any inactive databases fully match
7cd2a4b to
45bcbf5
Compare
|
@GavinFrazar See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacked on related change for
tsh db connect: #30527This PR changes
tsh db envandtsh db configsuch that when a given db name doesn't match any active cert fully,it calls the ListDatabases API to check if any inactive databases fully match.
Example UX Diff:
Suppose we have two databases, one a prefix of the other and not logged into:
Prior behavior: (Note that
postgres-2is used, because "postgres" is a prefix of its name)New behavior: