Skip to content

fix tsh db connect and tsh proxy db with logged in certs#30527

Merged
GavinFrazar merged 3 commits intomasterfrom
gavinfrazar/fix-tsh-db-connect-prefix
Aug 16, 2023
Merged

fix tsh db connect and tsh proxy db with logged in certs#30527
GavinFrazar merged 3 commits intomasterfrom
gavinfrazar/fix-tsh-db-connect-prefix

Conversation

@GavinFrazar
Copy link
Copy Markdown
Contributor

@GavinFrazar GavinFrazar commented Aug 16, 2023

fixes #30486

functional change is just a single line of the diff, the rest is an update to tests.

When I originally made the changes that caused this issue, I actually intended for the behavior cited in the issue, but I can see how it would be confusing to a user.

@github-actions github-actions Bot added size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Aug 16, 2023
@GavinFrazar GavinFrazar added database-access Database access related issues and PRs backport/branch/v13 labels Aug 16, 2023
@GavinFrazar GavinFrazar requested a review from smallinsky August 16, 2023 00:17
@GavinFrazar GavinFrazar requested a review from greedy52 August 16, 2023 01:20
@GavinFrazar
Copy link
Copy Markdown
Contributor Author

flaky test detector failure is just a timeout issue. I've already done everything I can to speed up these tests and it's best that everything in TestTshDB runs in parallel for the overall test package speed. @smallinsky up to you, but I'd appreciate if you just comment /excludeflake TestTshDB :)

Copy link
Copy Markdown
Contributor

@smallinsky smallinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flaky test detector failure is just a timeout issue. I've already done everything I can to speed up these tests and it's best that everything in TestTshDB runs in parallel for the overall test package speed. @smallinsky up to you, but I'd appreciate if you just comment /excludeflake TestTshDB :)

@GavinFrazar
I think that only GH admins can do that so we need to ask either @zmb3 or @r0mant

Comment thread tool/tsh/common/db.go
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Aug 16, 2023

/excludeflake TestTshDB

@GavinFrazar GavinFrazar enabled auto-merge August 16, 2023 15:53
@GavinFrazar GavinFrazar added this pull request to the merge queue Aug 16, 2023
Merged via the queue into master with commit a73e87f Aug 16, 2023
@GavinFrazar GavinFrazar deleted the gavinfrazar/fix-tsh-db-connect-prefix branch August 16, 2023 16:28
@public-teleport-github-review-bot
Copy link
Copy Markdown

@GavinFrazar See the table below for backport results.

Branch Result
branch/v13 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database-access Database access related issues and PRs size/sm tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tsh db connect - resource name collision should use best match

4 participants