Add secure credentials for API client tests#30518
Merged
Conversation
Joerger
force-pushed
the
joerger/remove-insecure-api-client-testing
branch
from
ef7365d to
176b6d2
Compare
Joerger
force-pushed
the
joerger/remove-insecure-api-client-testing
branch
from
176b6d2 to
a46d623
Compare
smallinsky
approved these changes
Aug 17, 2023
Joerger
force-pushed
the
joerger/remove-insecure-api-client-testing
branch
from
a46d623 to
57af62d
Compare
Contributor
Author
|
@ibeckermayer Friendly ping to review |
ibeckermayer
approved these changes
Aug 21, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Joerger
added a commit
that referenced
this pull request
Aug 22, 2023
* Move mockServer into a separate file. * Refactor mock server and client test. * Use mTLS in client tests. * Move mtls test helpers into a new package for reusability.
Joerger
added a commit
that referenced
this pull request
Aug 22, 2023
* Move mockServer into a separate file. * Refactor mock server and client test. * Use mTLS in client tests. * Move mtls test helpers into a new package for reusability.
Joerger
added a commit
that referenced
this pull request
Aug 22, 2023
* Move mockServer into a separate file. * Refactor mock server and client test. * Use mTLS in client tests. * Move mtls test helpers into a new package for reusability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes an old TODO I left to use secure credentials in api client tests.
I also did some minor refactors to the mock server and affected tests.
This is also needed in #30203 since Per-rpc MFA creds require a secure client connection.
I recommend reviewing commit by commit as the overall diff is hard to follow.