Bigcommerce gcp ha support #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…store-backed events, and firestore backend storage
russjones
approved these changes
Sep 24, 2019
|
|
||
| // Upload uploads object to GCS bucket, reads the contents of the object from reader | ||
| // and returns the target GCS bucket path in case of successful upload. | ||
| func (h *Handler) Upload(ctx context.Context, sessionID session.ID, reader io.Reader) (string, error) { |
There was a problem hiding this comment.
What happens if the session ID is the same as an existing session recording? Will it be clobbered?
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.