Fix flaky test TestImportantModalSemaphore#29880
Merged
Conversation
Joerger
commented
Aug 1, 2023
Contributor
Author
There was a problem hiding this comment.
Note: require.Equal does not allow comparing int to uint32.
Contributor
There was a problem hiding this comment.
FYI you can cast the values too, but this is fine as well.
codingllama
reviewed
Aug 1, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Contributor
There was a problem hiding this comment.
FYI you can cast the values too, but this is fine as well.
codingllama
reviewed
Aug 1, 2023
codingllama
approved these changes
Aug 1, 2023
codingllama
reviewed
Aug 1, 2023
…ake timeout less aggressive.
Joerger
force-pushed
the
joerger/fix-flaky-test-TestImportantModalSemaphore
branch
from
d5ce31b to
1a9c2e1
Compare
codingllama
approved these changes
Aug 1, 2023
jakule
approved these changes
Aug 1, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from xacrimon
Joerger
added a commit
that referenced
this pull request
Aug 2, 2023
…ake timeout less aggressive. (#29880)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
* * Enable headless authentication event watch. (#28234) * Add WatchPendingHeadlessAuthentications rpc. * Fix headless authentication matching logic for watcher (#28843) * Fix headless authentication matching logic for watcher and add test. * Move hasWatchPermissionForKind to a separate function. * Clean up hasWatchPermissionForKind. * Cleanup test code with suggestions from review. * Refactor Gateway Cert Reissuer and tshd events client (#28782) * - Move tshd events client into the daemon service. - Replace gatway cert reissuer with a more reusable retryWithRelogin method. * Resolve comments. * Teleport Connect headless watcher (#28844) * Implement headless watcher backend for Teleport Connect. * Add headless watcher to tshd daemon service. * Add SendPendingHeadlessAuthentication rpc to tshd events service. * Add UpdateHeadlessAuthenticationState rpc to the daemon service. * Address comments. * Tune Headless Watcher retry logic in Teleport Connect (#29410) * Reduce headless watcher max backoff period to 90s; Propogate watcher error properly; Don't retry on not implemented error. * Stop watcher if it wasn't stopped already. * Implement headless watcher approval logic in the Electron App. (#29097) * Fix uncaught merge conflict. * Fix call count race condition; Fix grpc server stop race condition; Make timeout less aggressive. (#29880)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
service.callCountsby usingatomiccounts insteadserver.Serveandserver.GracefulStop- See fix flaky teleterm daemon test #29218Closes #29879 (comment)