Skip to content

fix flaky teleterm daemon test#29218

Merged
greedy52 merged 1 commit intomasterfrom
STeve/29216_fix_daemon_flakiness
Jul 18, 2023
Merged

fix flaky teleterm daemon test#29218
greedy52 merged 1 commit intomasterfrom
STeve/29216_fix_daemon_flakiness

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Jul 17, 2023

Fixes #29216

Related change #28782

@greedy52 greedy52 requested review from Joerger, ravicious and zmb3 July 17, 2023 20:42
@greedy52 greedy52 self-assigned this Jul 17, 2023
@greedy52 greedy52 added this pull request to the merge queue Jul 18, 2023
Merged via the queue into master with commit ed8d212 Jul 18, 2023
@greedy52 greedy52 deleted the STeve/29216_fix_daemon_flakiness branch July 18, 2023 00:18
@ravicious
Copy link
Copy Markdown
Member

ravicious commented Jul 18, 2023

I think this is also going to take care of this class of errors, right? cc @Joerger

     daemon_test.go:458: 
        	Error Trace:	/__w/teleport/teleport/lib/teleterm/daemon/daemon_test.go:458
        	            				/opt/go/src/runtime/asm_amd64.s:1598
make: *** [Makefile:705: test-go-unit] Error 1
        	Error:      	Received unexpected error:
        	            	grpc: the server has been stopped
        	Test:       	TestRetryWithRelogin/fails_on_concurrent_relogin_calls

     daemon_test.go:458: 
        	Error Trace:	/__w/teleport/teleport/lib/teleterm/daemon/daemon_test.go:458
        	            				/opt/go/src/runtime/asm_amd64.s:1598
        	Error:      	Received unexpected error:
        	            	grpc: the server has been stopped
        	Test:       	TestRetryWithRelogin/calls_the_function_once_if_it_returns_successfully

@greedy52
Copy link
Copy Markdown
Contributor Author

greedy52 commented Jul 18, 2023

I think this is also going to take care of this class of errors, right? cc @Joerger

     daemon_test.go:458: 
        	Error Trace:	/__w/teleport/teleport/lib/teleterm/daemon/daemon_test.go:458
        	            				/opt/go/src/runtime/asm_amd64.s:1598
make: *** [Makefile:705: test-go-unit] Error 1
        	Error:      	Received unexpected error:
        	            	grpc: the server has been stopped
        	Test:       	TestRetryWithRelogin/fails_on_concurrent_relogin_calls

     daemon_test.go:458: 
        	Error Trace:	/__w/teleport/teleport/lib/teleterm/daemon/daemon_test.go:458
        	            				/opt/go/src/runtime/asm_amd64.s:1598
        	Error:      	Received unexpected error:
        	            	grpc: the server has been stopped
        	Test:       	TestRetryWithRelogin/calls_the_function_once_if_it_returns_successfully

yes

greedy52 added a commit that referenced this pull request Jul 19, 2023
@greedy52
fix flaky teleterm daemon test (#29218)
933c186
@Joerger Joerger mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmb3 zmb3 zmb3 approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

Assignees

@greedy52 greedy52

Labels

flaky tests size/sm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lib/teleterm/daemon flakiness

4 participants

@greedy52 @ravicious @zmb3 @fspmarshall