remove origin in cloud converters#29770
Merged
GavinFrazar merged 1 commit intomasterfrom Aug 4, 2023
Merged
Conversation
GavinFrazar
changed the title
GavinFrazar
commented
Jul 30, 2023
| @@ -148,6 +148,7 @@ func (w *Watcher) fetchAndSend() { | |||
|
|
|||
| // Set the origin to Cloud indicating that the resource was imported from a cloud provider. | |||
| staticLabels[types.OriginLabel] = types.OriginCloud | |||
Contributor
Author
There was a problem hiding this comment.
discovery services will apply the label here btw
ravicious
approved these changes
Jul 31, 2023
GavinFrazar
force-pushed
the
gavinfrazar/remove-origin-in-converters
branch
from
56aa08f to
a6eef00
Compare
jakule
approved these changes
Aug 4, 2023
public-teleport-github-review-bot
Bot
removed request for
marcoandredinis and
mdwn
tigrato
approved these changes
Aug 4, 2023
* use cmp.Diff for readable test failures * expect the teleport.dev/cloud label in tests * remove teleport.dev/origin in aws label conversion func
GavinFrazar
force-pushed
the
gavinfrazar/remove-origin-in-converters
branch
from
a6eef00 to
272d049
Compare
|
@GavinFrazar See the table below for backport results.
|
GavinFrazar
added a commit
that referenced
this pull request
Sep 18, 2023
backports #29770 to branch/v13 * use cmp.Diff for readable test failures * expect the teleport.dev/cloud label in tests * remove teleport.dev/origin in aws label conversion func
GavinFrazar
added a commit
that referenced
this pull request
Sep 18, 2023
backports #29770 to branch/v12. * fix awsoidc tests * use cmp.Diff for readable test failures * expect the teleport.dev/cloud label in tests * remove teleport.dev/origin in aws label conversion func
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
backports #29770 to branch/v13 * use cmp.Diff for readable test failures * expect the teleport.dev/cloud label in tests * remove teleport.dev/origin in aws label conversion func
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
backports #29770 to branch/v12. * fix awsoidc tests * use cmp.Diff for readable test failures * expect the teleport.dev/cloud label in tests * remove teleport.dev/origin in aws label conversion func
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
teleport.dev/origin: cloudlabel in db and kube cluster conversion funcsOriginally this was done in #24977 but in #28917 I changed it back unaware of that awsoidc PR