Remove Origin from Database cloud converters#24977
Merged
marcoandredinis merged 1 commit intomasterfrom May 2, 2023
Merged
Conversation
github-actions
Bot
added
database-access
marcoandredinis
changed the title
zmb3
approved these changes
Apr 24, 2023
marcoandredinis
force-pushed
the
marco/no_origin_in_converters
branch
from
bce010d to
dfc4bbd
Compare
Contributor
Author
|
@fspmarshall @kimlisa |
marcoandredinis
force-pushed
the
marco/no_origin_in_converters
branch
from
dfc4bbd to
0a1c8f1
Compare
kimlisa
approved these changes
Apr 28, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
May 2, 2023
marcoandredinis
added a commit
that referenced
this pull request
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the Cloud origin when converting Cloud (AWS/Azure) resources into Teleport Databases assumes they will be created automatically, thus the Cloud Origin:
That's not the case for the new AWS OIDC Integration: the Database info is presented to the user but they must choose a Database a click on Create.
So, this ends up being nothing more than a shortcut to get the Database Details (instead of copy/pasting the endpoint, port, ... from AWS).
Those Databases must be created with Origin: Dynamic.
This PR changes the converters to not include the Origin.
Databases added by the Discovery service still get the Origin:Cloud but much later in the process, right before being actually created in Teleport.