[v13] add onboarding survey#29397
Merged
michellescripts merged 5 commits intobranch/v13from Jul 21, 2023
Merged
Conversation
michellescripts
changed the title
* update protos * create Posthog event for onboarding questionnaire submit
* Fix panic when fetching user preferences Closes #28740 * Prevent overwriting mismatched types in user preferences * Add error handling to user preferences service * GCI imports * Refactor user preferences test and logic This commit updates the approach for comparing equality in user preferences test. It introduces the use of the "go-cmp" library which provides more flexibility in handling comparison of struct elements, thus helping to catch any unexpected changes that could be overlooked with the standard equality checking. We also revised the logic to handle default preferences by overwriting values for better efficiency and readability, also removing unnecessary checking and merging of values. * Add comments to overwriteValues method in userpreferences.go Added detailed comments to better explain the overwriteValues function in userpreferences.go file. The comments clarify how the function uses proto.Ranges to iterate over fields and only overwrite non-nil/empty fields. * Apply some magic to preferences test * Change the import to avoid go.mod changed and match our other imports
* Display a survey during onboarding - Adds user context wrapper to the Welcome flow in order to update preferences - Sets selected resources on user preferences * imports & describes * named enums * remove onboard survey from oss - will be moved to /e - export shared types * refactor welcome - move new credential to welcome prop * refactor new credentails - container passes questionnaire to component * remove survey ls dispatch * pr feedback * Revert "pr feedback" This reverts commit 060f34fb60242856f233df6a1006c5192ea321fb.
michellescripts
force-pushed
the
michelle/v13-backport-survey
branch
from
4499ffb to
29ac6b3
Compare
ravicious
approved these changes
Jul 21, 2023
ryanclark
approved these changes
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports for Onboarding Questionnaire & Onboard user preferences; cc @jakule