Assist: gracefully handle errors on the frontend#27669
Merged
Conversation
ryanclark
force-pushed
the
ryan/new-assist-ui
branch
from
867faeb to
b10beef
Compare
justinas
force-pushed
the
justinas/assist-error-handling
branch
from
cf9249b to
0a6e4e7
Compare
justinas
changed the title
ryanclark
force-pushed
the
ryan/new-assist-ui
branch
2 times, most recently
from
1663c4c to
b949dd5
Compare
justinas
force-pushed
the
justinas/assist-error-handling
branch
from
0a6e4e7 to
6674078
Compare
kimlisa
approved these changes
Jun 13, 2023
justinas
added a commit
that referenced
this pull request
Jun 16, 2023
justinas
added a commit
that referenced
this pull request
Jun 19, 2023
* Return errors over Assist WS (#27174) * Return errors over Assist WS * Add test * Address code review comments Add check for the close message in assist WS * Use UTC for getting time * Gracefully handle errors in Assist frontend (#27669) * Bump e to include teleport.e#1634 * Fix error assertions in the test This test is removed altogether in #27075, but that has not been backported yet. --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/gravitational/teleport.e/issues/1489
For now errors do not have styling distinct from normal messages. I experimented with some approaches, but did not particularly like any of them 😅 I'm open to ideas if this is deemed important.