Merged
Conversation
jakule
force-pushed
the
jakule/assist-return-errors
branch
from
b74d793 to
b2bd553
Compare
rosstimothy
reviewed
Jun 2, 2023
jakule
force-pushed
the
jakule/assist-return-errors
branch
from
b2bd553 to
e70cccb
Compare
capnspacehook
approved these changes
Jun 2, 2023
Add check for the close message in assist WS
jakule
force-pushed
the
jakule/assist-return-errors
branch
from
e70cccb to
f545956
Compare
rosstimothy
approved these changes
Jun 7, 2023
justinas
pushed a commit
that referenced
this pull request
Jun 16, 2023
* Return errors over Assist WS * Add test * Address code review comments Add check for the close message in assist WS * Use UTC for getting time
justinas
added a commit
that referenced
this pull request
Jun 19, 2023
* Return errors over Assist WS (#27174) * Return errors over Assist WS * Add test * Address code review comments Add check for the close message in assist WS * Use UTC for getting time * Gracefully handle errors in Assist frontend (#27669) * Bump e to include teleport.e#1634 * Fix error assertions in the test This test is removed altogether in #27075, but that has not been backported yet. --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return error messages via WebSocket as a message that a client can understand instead of closing the WS without saying what went wrong.
Updates https://github.com/gravitational/teleport.e/issues/1489