[v12] Fetch ClusterAlerts a single time during login#27111
Merged
rosstimothy merged 1 commit intobranch/v12from May 30, 2023
Merged
[v12] Fetch ClusterAlerts a single time during login#27111rosstimothy merged 1 commit intobranch/v12from
rosstimothy merged 1 commit intobranch/v12from
Conversation
`onLogin` was inadvertently retrieving ClusterAlerts twice by explicitly retrieving them and by calling `onStatus`, which also gets the alerts so they are shown when `tsh status` is invoked. The portion of `onStatus` which prints the profile has been separated into `outputProfiles` so that `onLogin` may call that directly instead of `onStatus`.
github-actions
Bot
added
backport
size/sm
tsh
zmb3
approved these changes
May 30, 2023
Tener
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #26903 to branch/v12