Fetch ClusterAlerts a single time during login#26903
Merged
rosstimothy merged 1 commit intomasterfrom May 30, 2023
Merged
Conversation
Contributor
Author
|
|
github-actions
Bot
added
size/sm
tsh
Tener
approved these changes
May 25, 2023
Closed
zmb3
reviewed
May 26, 2023
| } | ||
| fmt.Println(out) | ||
| default: | ||
| printProfiles(cf.Debug, active, others, env, cf.Verbose) |
Collaborator
There was a problem hiding this comment.
printProfiles sounds very similar to outputProfiles, and calling the wrong one may result in unexpected behavior.
What do you think about inlining the contents of printProfiles here, so there's only one function for printing profiles?
zmb3
approved these changes
May 27, 2023
`onLogin` was inadvertently retrieving ClusterAlerts twice by explicitly retrieving them and by calling `onStatus`, which also gets the alerts so they are shown when `tsh status` is invoked. The portion of `onStatus` which prints the profile has been separated into `outputProfiles` so that `onLogin` may call that directly instead of `onStatus`.
rosstimothy
force-pushed
the
tross/login_cluster_alerts
branch
from
4b01e59 to
3478377
Compare
|
@rosstimothy See the table below for backport results.
|
This was referenced May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onLoginwas inadvertently retrieving ClusterAlerts twice by explicitly retrieving them and by callingonStatus, which also gets the alerts so they are shown whentsh statusis invoked. The portion ofonStatuswhich prints the profile has been separated intooutputProfilesso thatonLoginmay call that directly instead ofonStatus.Partly addresses #21841