Update dependencies for /integrations/kube-agent-updater#26909
Merged
Update dependencies for /integrations/kube-agent-updater#26909
/integrations/kube-agent-updater#26909Conversation
jentfoo
requested review from
adaadb6,
codingllama,
r0mant,
rosstimothy,
wadells and
zmb3
zmb3
reviewed
May 25, 2023
Collaborator
There was a problem hiding this comment.
The 0.4.0 update required a lot of manual fixes in Teleport. Are we sure no changes are necessary here?
Contributor
Author
There was a problem hiding this comment.
It does seem that I was optimistic in including everything here, I am working on reducing this change set so that tests will pass
Contributor
Author
There was a problem hiding this comment.
I left this update in because make test-kube-agent-updater seems to be passing, I will watch for other unit test failures.
codingllama
reviewed
May 25, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Looks like you've got a few breakages.
Also, FYI @hugoShaka.
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.26.1 to 0.27.2. - [Commits](kubernetes/apimachinery@v0.26.1...v0.27.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/jonboulle/clockwork](https://github.com/jonboulle/clockwork) from 0.3.0 to 0.4.0. - [Release notes](https://github.com/jonboulle/clockwork/releases) - [Commits](jonboulle/clockwork@v0.3.0...v0.4.0) --- updated-dependencies: - dependency-name: github.com/jonboulle/clockwork dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.3. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.2...v1.8.3) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
jentfoo
force-pushed
the
jent/integrations_updates
branch
from
4cb15ca to
bd1093d
Compare
Contributor
Author
|
Thank you @zmb3 and @codingllama. I just updated the PR and the description. It looks like most of these updates introduced one issue or another. I have reduced this to a much smaller set of updates, but which should be safe 🤞 |
hugoShaka
approved these changes
May 25, 2023
public-teleport-github-review-bot
Bot
removed request for
adaadb6,
jimbishopp,
r0mant,
rosstimothy and
wadells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency updates that should apply cleanly for
/integrations/kube-agent-updater. This should reduce some of the PR's opened once #26867 is merged. Other PR's don't have CVE's associated to them so we may choose to close those PR's when #26867 is merged.