Conversation
Update Dependabot with the following: * Add `jentfoo` to reviewers list * Remove `crypto` ignore on `api` (no longer using forked version) * Add configurations for missing gomod paths
|
Do we really need to include everything under |
|
Examples are definitely lower priority. But if we expect people to reference or start from them, it seems like we should keep them up to date. That said this PR is expanding the scope fairly dramatically, so I could be convinced to do examples as another iteration. |
Some of the stuff under |
|
I think most users will be required to change |
|
+1 for removing examples from automatic updates - I don't want to spend eng time every week touching them up.
We should certainly do that, calling prod code "examples" is highly misleading. Who is a good person to tag for the refactor? |
codingllama
left a comment
There was a problem hiding this comment.
Overall looks good, thanks Jent.
Co-authored-by: Alan Parra <alan.parra@goteleport.com>
| time: "09:00" # 9am UTC | ||
| ignore: | ||
| # Forked/replaced dependencies | ||
| - dependency-name: golang.org/x/crypto |
|
I have removed I will try to today to get a few more PR's up to update these dependencies before the scheduled run (reduce the Dependabot qty) |
I kind of disagree here, I don't think examples should create a continuous maintenance burden. It's important that they remain useful (as in they work with current Teleport), but a pre-release check could do. Touching up their dependencies, barring for CVEs, doesn't seem important. |
Update Dependabot with the following:
jentfooto reviewers listcryptoignore onapi(no longer using forked version)Although we are looking to explore Renovate I think we should still correct these gaps soon. As an alternative I am open to correcting these gaps with Renovate first to help validate Renovate and then just merging this for completeness after.