Fix grpcbox for arm64 and undo protoc rollback#26758
Merged
codingllama merged 2 commits intomasterfrom May 23, 2023
Merged
Conversation
codingllama
changed the title
This was referenced May 23, 2023
espadolini
approved these changes
May 23, 2023
tigrato
approved these changes
May 23, 2023
public-teleport-github-review-bot
Bot
removed request for
ravicious and
tobiaszheller
ravicious
approved these changes
May 23, 2023
codingllama
added a commit
that referenced
this pull request
May 23, 2023
* Revert protoc downgrade * Use correct protoc URL for arm64
codingllama
added a commit
that referenced
this pull request
May 23, 2023
* Revert protoc downgrade * Use correct protoc URL for arm64
codingllama
added a commit
that referenced
this pull request
May 23, 2023
* Revert protoc downgrade * Use correct protoc URL for arm64
codingllama
added a commit
that referenced
this pull request
May 25, 2023
* Add the babybox Dockerfile and Makefile * Change Makefiles to use the babybox * Change buildbox to use version args * Keep the old "if BUILDARCH" on protoc install * Drop --platform directive on babybox (its platform doesn't matter) * Use mktemp to download protoc * Remove defaults from ARGs * Copy ARG comments to buildbox Dockerfile * Rename babybox to grpcbox * Fix grpcbox for arm64 and undo protoc rollback (#26758) * Revert protoc downgrade * Use correct protoc URL for arm64
codingllama
added a commit
that referenced
this pull request
May 25, 2023
* Add a codegen-focused buildbox (#26640) * Add the babybox Dockerfile and Makefile * Change Makefiles to use the babybox * Change buildbox to use version args * Keep the old "if BUILDARCH" on protoc install * Drop --platform directive on babybox (its platform doesn't matter) * Use mktemp to download protoc * Remove defaults from ARGs * Copy ARG comments to buildbox Dockerfile * Rename babybox to grpcbox * Fix grpcbox for arm64 and undo protoc rollback (#26758) * Revert protoc downgrade * Use correct protoc URL for arm64 * Adapt cached protoc plugins for v11
codingllama
added a commit
that referenced
this pull request
May 25, 2023
* Add a codegen-focused buildbox (#26640) * Add the babybox Dockerfile and Makefile * Change Makefiles to use the babybox * Change buildbox to use version args * Keep the old "if BUILDARCH" on protoc install * Drop --platform directive on babybox (its platform doesn't matter) * Use mktemp to download protoc * Remove defaults from ARGs * Copy ARG comments to buildbox Dockerfile * Rename babybox to grpcbox * Fix grpcbox for arm64 and undo protoc rollback (#26758) * Revert protoc downgrade * Use correct protoc URL for arm64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the protoc download URL for arm64 (actually
aarch64in the container) and undo the accidental protoc version rollback in #26640.