[v12] Add a codegen-focused buildbox#26741
Merged
codingllama merged 2 commits intobranch/v12from May 25, 2023
Merged
Conversation
Contributor
Author
|
Patched with #26758 and re-tested, PTAL. |
* Add the babybox Dockerfile and Makefile * Change Makefiles to use the babybox * Change buildbox to use version args * Keep the old "if BUILDARCH" on protoc install * Drop --platform directive on babybox (its platform doesn't matter) * Use mktemp to download protoc * Remove defaults from ARGs * Copy ARG comments to buildbox Dockerfile * Rename babybox to grpcbox
* Revert protoc downgrade * Use correct protoc URL for arm64
codingllama
force-pushed
the
codingllama/backport/26640-v12
branch
from
cd7b340 to
fcf1056
Compare
rosstimothy
reviewed
May 23, 2023
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
It looks like the first commit and description of this PR still reference babybox. Can you please update them now that we're using grpcbox instead?
Contributor
Author
|
Fixed description. The first commit is squashed so the title is generic, the description has the same history as master so I'd rather not change it. |
rosstimothy
approved these changes
May 23, 2023
Contributor
Author
|
Friendly ping? |
Contributor
Author
|
Friendly ping @jakule @nklaassen @timothyb89 @tobiaszheller ? |
jakule
approved these changes
May 24, 2023
timothyb89
approved these changes
May 25, 2023
public-teleport-github-review-bot
Bot
removed request for
nklaassen and
tobiaszheller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #26640 and #26758 to branch/v12
Add the "grpcbox", a codegen-focused buildbox. It's meant to cut down build
times for
make grpcand related commands.The original buildbox still retains the ability to build protos, as GHA
pipelines require it to run make protos-up-to-date/host. That could also,
in the future, be changed to rely on the grpcbox instead.